Skip to content

Conversation

@snowystinger
Copy link
Member

@snowystinger snowystinger commented Oct 10, 2019

We only have one scale of icons now, set it to 'M' so we use the correct viewbox

All workflow icons will now be the 18px size. They still obey tshirt sizes and the css dictated scaling factor to large. They no longer need to swap paths though, so we are setting the scale to 'M' for what's been distributed to us.

Closes

✅ Pull Request Checklist:

  • Included link to corresponding Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exist for this component).
  • Looked at the Accessibility Standard and/or talked to @mijordan about Accessibility for this feature.

📝 Test Instructions:

🧢 Your Team:

@github-actions
Copy link

Build successful! View the storybook

@snowystinger snowystinger merged commit 1293072 into master Oct 10, 2019
@snowystinger snowystinger deleted the fix-icons-no-more-2-sizes branch October 10, 2019 22:54
@github-actions
Copy link

Build successful! View the storybook

devongovett added a commit that referenced this pull request Jul 25, 2024
* Tooltips without animation

* adding animations that partially work

* animations working

* animation refactor

* changing svg fill set by css not prop

* adding autodocs

* fixed storybook autodocs

* improving padding and left/right tooltip placement

* removing unnecessary spread

Co-authored-by: Devon Govett <govett@adobe.com>

Co-authored-by: Kyle Taborski <ktabors@yahoo.com>
Co-authored-by: Devon Govett <devongovett@gmail.com>
Co-authored-by: Devon Govett <govett@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants