Skip to content

Removing isOpen/defaultOpen from combobox docs #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 14, 2021
Merged

Removing isOpen/defaultOpen from combobox docs #1948

merged 4 commits into from
Jun 14, 2021

Conversation

@LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented May 24, 2021

Closes #1941

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@LFDanLu
Copy link
Member Author

LFDanLu commented May 24, 2021

DNM until release

@adobe-bot
Copy link

adobe-bot commented May 24, 2021

Build successful! 🎉

@adobe-bot
Copy link

adobe-bot commented May 25, 2021

Build successful! 🎉

@adobe-bot
Copy link

adobe-bot commented Jun 9, 2021

Build successful! 🎉

@dannify dannify added the documentation Improvements or additions to documentation label Jun 14, 2021
@adobe-bot
Copy link

adobe-bot commented Jun 14, 2021

Build successful! 🎉

@dannify dannify changed the title (DNM) Removing isOpen/defaultOpen from combobox docs Removing isOpen/defaultOpen from combobox docs Jun 14, 2021
@dannify dannify merged commit 5bf9b96 into main Jun 14, 2021
@dannify dannify deleted the issue_1941 branch June 14, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dannify dannify Awaiting requested review from dannify

@devongovett devongovett Awaiting requested review from devongovett

@snowystinger snowystinger Awaiting requested review from snowystinger

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Combobox docs to remove isOpen/defaultOpen

5 participants

@LFDanLu @adobe-bot @dannify @devongovett