Adding TableView/useTable/useTableState docs mdx #2011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that it matches up with the ARIA roles better
Breaks apart the large example into separate components with individual code blocks.
|
Build successful! 🎉 |
|
Build successful! 🎉 |
LFDanLu
commented
Jun 21, 2021
Member
Author
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
Thanks for all the updates, looks really good to me. Just two really small things noted
| key anywhere in the row selects it. | ||
|
|
||
| We'll use the <TypeLink links={selectionDocs.links} type={selectionDocs.exports.SelectionManager} /> object exposed | ||
| by the `state` to determine if a row is selected, and render a pink background if so. We'll also use the <TypeLink links={focusDocs.links} type={focusDocs.exports.useFocusRing} /> |
Member
Author
There was a problem hiding this comment.
Suggested change
| by the `state` to determine if a row is selected, and render a pink background if so. We'll also use the <TypeLink links={focusDocs.links} type={focusDocs.exports.useFocusRing} /> | |
| by the `state` to determine if a row is selected, and render a blueviolet background if so. We'll also use the <TypeLink links={focusDocs.links} type={focusDocs.exports.useFocusRing} /> |
| ]; | ||
|
|
||
| return ( | ||
| <Flex flexGrow={1} maxWidth="size-6000"> |
Member
Author
There was a problem hiding this comment.
Do we wanna remove the Flex wrapper from the rest of the examples for consistency?
Member
There was a problem hiding this comment.
yeah I think Danni hasn't pushed her changes yet.
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
added 2 commits
June 21, 2021 14:46
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
Member
|
To be merged after release |
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1648 and #1913
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: