Merged
Conversation
# Conflicts: # package.json
|
Build successful! 🎉 |
ross-pfahler
previously approved these changes
Feb 19, 2020
Collaborator
ross-pfahler
left a comment
ross-pfahler
left a comment
There was a problem hiding this comment.
looking good; do we need to hook up the CLA bot also?
| , dom); | ||
| ``` | ||
|
|
||
| ### Webpack |
Collaborator
There was a problem hiding this comment.
do we not want instructions for other bundlers anymore? Or would these be moved into the docs?
Member
There was a problem hiding this comment.
to be fair, we got rid of instructions for all bundlers :P
# Conflicts: # .circleci/config.yml
|
Build successful! 🎉 |
Member
it's already hooked up. see checks on this PR. |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
devongovett
approved these changes
Feb 21, 2020
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.