Skip to content

Chromatic fix animation flakiness #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 16, 2021
Merged

Chromatic fix animation flakiness #2109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
89bdb3c
use pauseAnimationAtEnd
snowystinger Jul 14, 2021
13fedc6
Merge branch 'main' into chromatic-fix-animation-flakiness
snowystinger Jul 14, 2021
3e7d644
use preload syntax instead of embedded fonts, i think we still weren'…
snowystinger Jul 15, 2021
c763a9d
Merge branch 'main' into chromatic-fix-animation-flakiness
snowystinger Jul 15, 2021
c80722e
Merge branch 'main' into chromatic-fix-animation-flakiness
snowystinger Jul 15, 2021
91195d2
Merge branch 'main' into chromatic-fix-animation-flakiness
snowystinger Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 0 additions & 57 deletions .chromatic/custom-addons/chromatic/chromatic.css
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion .chromatic/custom-addons/chromatic/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import {locales, scales, themes} from '../../constants';
import {makeDecorator} from '@storybook/addons';
import {Provider, View} from '@adobe/react-spectrum';
import React, {useEffect} from 'react';
import styles from './chromatic.css';

export const withChromaticProvider = makeDecorator({
name: 'withChromaticProvider',
Expand Down
23 changes: 23 additions & 0 deletions .chromatic/preview-head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,24 @@
<link rel="preload" href="https://use.typekit.net/uma8ayv.css" as="style" />

<link rel="preload" href="https://use.typekit.net/af/cb695f/000000000000000000017701/27/l?primer=7cdcb44be4a7db8877ffa5c0007b8dd865b3bbc383831fe2ea177f62257a9191&fvd=n4&v=3" as="font" crossorigin="anonymous" />
<link rel="preload" href="https://use.typekit.net/af/cb695f/000000000000000000017701/27/d?primer=7cdcb44be4a7db8877ffa5c0007b8dd865b3bbc383831fe2ea177f62257a9191&fvd=n4&v=3" as="font" crossorigin="anonymous" />
<link rel="preload" href="https://use.typekit.net/af/cb695f/000000000000000000017701/27/a?primer=7cdcb44be4a7db8877ffa5c0007b8dd865b3bbc383831fe2ea177f62257a9191&fvd=n4&v=3" as="font" crossorigin="anonymous" />

<link rel="preload" href="https://use.typekit.net/af/74ffb1/000000000000000000017702/27/l?primer=7cdcb44be4a7db8877ffa5c0007b8dd865b3bbc383831fe2ea177f62257a9191&fvd=i4&v=3" as="font" crossorigin="anonymous" />
<link rel="preload" href="https://use.typekit.net/af/74ffb1/000000000000000000017702/27/d?primer=7cdcb44be4a7db8877ffa5c0007b8dd865b3bbc383831fe2ea177f62257a9191&fvd=i4&v=3" as="font" crossorigin="anonymous" />
<link rel="preload" href="https://use.typekit.net/af/74ffb1/000000000000000000017702/27/a?primer=7cdcb44be4a7db8877ffa5c0007b8dd865b3bbc383831fe2ea177f62257a9191&fvd=i4&v=3" as="font" crossorigin="anonymous" />

<link rel="preload" href="https://use.typekit.net/af/eaf09c/000000000000000000017703/27/l?primer=7cdcb44be4a7db8877ffa5c0007b8dd865b3bbc383831fe2ea177f62257a9191&fvd=n7&v=3" as="font" crossorigin="anonymous" />
<link rel="preload" href="https://use.typekit.net/af/eaf09c/000000000000000000017703/27/d?primer=7cdcb44be4a7db8877ffa5c0007b8dd865b3bbc383831fe2ea177f62257a9191&fvd=n4&v=3" as="font" crossorigin="anonymous" />
<link rel="preload" href="https://use.typekit.net/af/eaf09c/000000000000000000017703/27/a?primer=7cdcb44be4a7db8877ffa5c0007b8dd865b3bbc383831fe2ea177f62257a9191&fvd=n4&v=3" as="font" crossorigin="anonymous" />

<link rel="preload" href="https://use.typekit.net/af/40207f/0000000000000000000176ff/27/l?primer=7cdcb44be4a7db8877ffa5c0007b8dd865b3bbc383831fe2ea177f62257a9191&fvd=n4&v=3" as="font" crossorigin="anonymous" />
<link rel="preload" href="https://use.typekit.net/af/40207f/0000000000000000000176ff/27/d?primer=7cdcb44be4a7db8877ffa5c0007b8dd865b3bbc383831fe2ea177f62257a9191&fvd=n4&v=3" as="font" crossorigin="anonymous" />
<link rel="preload" href="https://use.typekit.net/af/40207f/0000000000000000000176ff/27/a?primer=7cdcb44be4a7db8877ffa5c0007b8dd865b3bbc383831fe2ea177f62257a9191&fvd=n4&v=3" as="font" crossorigin="anonymous" />

<link rel="preload" href="https://use.typekit.net/af/505d17/00000000000000003b9aee44/27/l?primer=7cdcb44be4a7db8877ffa5c0007b8dd865b3bbc383831fe2ea177f62257a9191&fvd=n4&v=3" as="font" crossorigin="anonymous" />
<link rel="preload" href="https://use.typekit.net/af/505d17/00000000000000003b9aee44/27/d?primer=7cdcb44be4a7db8877ffa5c0007b8dd865b3bbc383831fe2ea177f62257a9191&fvd=n4&v=3" as="font" crossorigin="anonymous" />
<link rel="preload" href="https://use.typekit.net/af/505d17/00000000000000003b9aee44/27/a?primer=7cdcb44be4a7db8877ffa5c0007b8dd865b3bbc383831fe2ea177f62257a9191&fvd=n4&v=3" as="font" crossorigin="anonymous" />


<link rel="stylesheet" href="https://use.typekit.net/uma8ayv.css" />
2 changes: 1 addition & 1 deletion packages/@react-spectrum/menu/chromatic/MenuTrigger.chromatic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const meta: Meta<SpectrumMenuTriggerProps> = {
parameters: {
chromaticProvider: {colorSchemes: ['light'], locales: ['en-US'], scales: ['medium'], disableAnimations: true},
// chromatic needs a bit more time than disableAnimations allows
chromatic: {delay: 2000}
chromatic: {pauseAnimationAtEnd: true}
},
decorators: [Story => <div style={{display: 'flex', width: 'auto', margin: '250px 0'}}><Story /></div>]
};
Expand Down
2 changes: 1 addition & 1 deletion packages/@react-spectrum/menu/chromatic/MenuTriggerRTL.chromatic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const meta: Meta = {
parameters: {
chromaticProvider: {colorSchemes: ['light'], locales: ['ar-AE'], scales: ['medium'], disableAnimations: true},
// chromatic needs a bit more time than disableAnimations allows
chromatic: {delay: 2000}
chromatic: {pauseAnimationAtEnd: true}
},
decorators: [Story => <div style={{display: 'flex', width: 'auto', margin: '250px 0'}}><Story /></div>]
};
Expand Down
2 changes: 1 addition & 1 deletion packages/@react-spectrum/tooltip/chromatic/TooltipTrigger.chromatic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const meta: Meta<SpectrumTooltipTriggerProps> = {
parameters: {
chromaticProvider: {colorSchemes: ['light'], locales: ['en-US'], scales: ['medium'], disableAnimations: true},
// chromatic needs a bit more time than disableAnimations allows
chromatic: {delay: 2000}
chromatic: {pauseAnimationAtEnd: true}
}
};

Expand Down