Skip to content

Fix decimals in percent number fields without minimumFractionDigits #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Fix decimals in percent number fields without minimumFractionDigits #2224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@internationalized/number/src/NumberParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,8 @@ const nonLiteralParts = new Set(['decimal', 'fraction', 'integer', 'minusSign',

function getSymbols(formatter: Intl.NumberFormat, intlOptions: Intl.ResolvedNumberFormatOptions, originalOptions: Intl.NumberFormatOptions): Symbols {
// Note: some locale's don't add a group symbol until there is a ten thousands place
let allParts = formatter.formatToParts(-10000.1);
let posAllParts = formatter.formatToParts(10000.1);
let allParts = formatter.formatToParts(-10000.111);
let posAllParts = formatter.formatToParts(10000.111);
let singularParts = formatter.formatToParts(1);

let minusSign = allParts.find(p => p.type === 'minusSign')?.value ?? '-';
Expand Down
2 changes: 2 additions & 0 deletions packages/@internationalized/number/test/NumberParser.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,11 @@ describe('NumberParser', function () {
expect(new NumberParser('en-US', {style: 'percent'}).isValidPartialNumber('10')).toBe(true);
expect(new NumberParser('en-US', {style: 'percent'}).isValidPartialNumber('10.5')).toBe(false);
expect(new NumberParser('en-US', {style: 'percent', minimumFractionDigits: 2}).isValidPartialNumber('10.5')).toBe(true);
expect(new NumberParser('en-US', {style: 'percent', maximumFractionDigits: 2}).isValidPartialNumber('10.5')).toBe(true);
expect(new NumberParser('en-US', {style: 'percent'}).isValidPartialNumber('10%')).toBe(true);
expect(new NumberParser('en-US', {style: 'percent'}).isValidPartialNumber('10.5%')).toBe(false);
expect(new NumberParser('en-US', {style: 'percent', minimumFractionDigits: 2}).isValidPartialNumber('10.5%')).toBe(true);
expect(new NumberParser('en-US', {style: 'percent', maximumFractionDigits: 2}).isValidPartialNumber('10.5%')).toBe(true);
expect(new NumberParser('en-US', {style: 'percent'}).isValidPartialNumber('%')).toBe(true);
expect(new NumberParser('en-US', {style: 'percent'}).isValidPartialNumber('10 %')).toBe(true);
});
Expand Down