Skip to content

Conversation

@snowystinger
Copy link
Member

Lets see what we're at and if this works :)

Closes

✅ Pull Request Checklist:

  • Included link to corresponding Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Team:

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #228 into master will decrease coverage by 0.02%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   69.55%   69.52%   -0.03%     
==========================================
  Files         206      206              
  Lines        3961     3961              
  Branches      839      841       +2     
==========================================
- Hits         2755     2754       -1     
  Misses        625      625              
- Partials      581      582       +1
Impacted Files Coverage Δ
...s/@react-spectrum/menu-trigger/src/MenuTrigger.tsx 93.33% <ø> (ø) ⬆️
packages/@react-aria/menu-trigger/src/useMenu.ts 72.72% <ø> (ø) ⬆️
...ckages/@react-spectrum/menu-trigger/src/context.ts 100% <ø> (ø) ⬆️
packages/@react-spectrum/menu-trigger/src/Menu.tsx 85.71% <ø> (+0.52%) ⬆️
...ges/@react-aria/menu-trigger/src/useMenuTrigger.ts 91.3% <100%> (+0.39%) ⬆️
...eact-aria/selection/src/useSelectableCollection.ts 52% <75%> (+3.13%) ⬆️

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

dannify
dannify previously approved these changes Feb 28, 2020
@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@dannify dannify merged commit 399ac01 into master Feb 28, 2020
@dannify dannify deleted the add-code-coverage branch February 28, 2020 23:01
dannify added a commit that referenced this pull request Mar 2, 2020
devongovett pushed a commit that referenced this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants