Skip to content

Always make space for the sort icon #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devongovett merged 6 commits into from
Oct 15, 2021
Merged

Always make space for the sort icon #2318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a47b772
Always make space for the sort icon
snowystinger Sep 10, 2021
c4809d2
fixing sort icon position in table
LFDanLu Sep 10, 2021
2fbf36a
Merge branch 'main' into fix-prioritize-sorting-icon
LFDanLu Sep 10, 2021
fe0f4a1
Update packages/@adobe/spectrum-css-temp/components/table/index.css
snowystinger Sep 10, 2021
8d9b4c5
Merge branch 'main' into fix-prioritize-sorting-icon
snowystinger Oct 8, 2021
00879ad
Merge branch 'main' into fix-prioritize-sorting-icon
devongovett Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/@adobe/spectrum-css-temp/components/table/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ governing permissions and limitations under the License.
/* specificity must be higher than `.spectrum-Icon` */
svg.spectrum-Table-sortedIcon {
display: none;
flex: 0 0 auto;
margin-inline-start: var(--spectrum-table-header-sort-icon-gap);
min-inline-size: var(--spectrum-icon-arrow-down-small-width);

Expand All @@ -42,8 +43,16 @@ svg.spectrum-Table-sortedIcon {
border-right-width: 1px;
border-right-style: solid;
}
.spectrum-Table-headCellContents {
display: inline-block;
min-inline-size: 0;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
}

.spectrum-Table-headCell {
display: flex;
box-sizing: border-box;
font-size: var(--spectrum-table-header-text-size);
font-weight: var(--spectrum-table-header-text-font-weight);
Expand Down
2 changes: 1 addition & 1 deletion packages/@react-spectrum/table/src/TableView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ function TableColumnHeader({column}) {
}>
{columnProps.hideHeader ?
<VisuallyHidden>{column.rendered}</VisuallyHidden> :
column.rendered
<div className={classNames(styles, 'spectrum-Table-headCellContents')}>{column.rendered}</div>
}
{columnProps.allowsSorting &&
<ArrowDownSmall UNSAFE_className={classNames(styles, 'spectrum-Table-sortedIcon')} />
Expand Down