Fixing focus ring and type ahead stories in ListView #2325
Merged
+49
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LFDanLu
requested review from
dannify,
devongovett and
snowystinger
as code owners
|
Build successful! 🎉 |
|
Build successful! 🎉 |
| let target = getCell(tree, 'Baz'); | ||
| let grid = tree.getByRole('grid'); | ||
| act(() => grid.focus()); | ||
| fireEvent.keyDown(grid, {key: 'B'}); |
Member
There was a problem hiding this comment.
please include the keyUp as well
…rum into fix_listview_focusring
snowystinger
approved these changes
Sep 16, 2021
Member
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
lgtm tested in chrome/safari/ff
|
Build successful! 🎉 |
dannify
approved these changes
Sep 20, 2021
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
majornista
pushed a commit
that referenced
this pull request
Oct 5, 2021
* fixing focus ring and type ahead stories * fixing lint * adding keyup to listview tests Co-authored-by: Danni <drobinson@livefyre.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: