Conversation
LFDanLu
requested review from
dannify,
devongovett and
snowystinger
as code owners
LFDanLu
commented
Mar 5, 2020
Comment on lines
-190
to
-196
| .spectrum-Dialog--dismissable { | ||
| .spectrum-Dialog-closeButton { | ||
| display: block; | ||
| } |
Member
Author
There was a problem hiding this comment.
Unsure why this existed in the first place, but it was causing the focus ring to be slightly off center. Lemme know if we needed this
Member
There was a problem hiding this comment.
Might need to verify with @snowystinger for this one
Member
There was a problem hiding this comment.
this was just here because closeButton was display none unless the dialog was dismissable
however, i think i changed it to be a js solution instead, so you should be fine removing this
i don't know if css will like this change though?
|
Build successful! 🎉 |
MidnightCoder06
approved these changes
Mar 5, 2020
Contributor
MidnightCoder06
left a comment
MidnightCoder06
left a comment
There was a problem hiding this comment.
Visually lgtm. Assuming that bit of css is not needed, issue seems fixed 👍
|
Build successful! 🎉 |
snowystinger
approved these changes
Mar 9, 2020
|
Build successful! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://jira.corp.adobe.com/browse/RSP-1523
✅ Pull Request Checklist:
📝 Test Instructions:
Go to the "isDismissible" and "with hero, isDismissible" Dialog stories in storybook and confirm that the 'X' button is 12px/8px from the edge of the dialog in medium/large scale respectively. Try RTL locale as well.