Support for wrappers around collection nodes#258
Merged
Conversation
…ection-wrappers # Conflicts: # packages/@react-spectrum/menu-trigger/src/Menu.tsx # packages/@react-stately/collections/src/types.ts
devongovett
changed the title
…ection-wrappers # Conflicts: # packages/@react-stately/collections/src/types.ts
|
Build successful! 🎉 |
|
Build successful! 🎉 |
dannify
approved these changes
Mar 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for wrapper elements like
<DialogTrigger>to be used around<Item>elements inside CollectionBuilder. This is done by supporting agetCollectionNodemethod on components, which returns the child element and the wrapper to be added back later during rendering.CollectionBuilder has been refactored so that
<Item>and<Section>use this same method, rather than doing hard coded checks for specific element types. They each return partial node objects, which are recursively built into their final full nodes. This will make adding additional elements like<Cell>and<SelectionGroup>much easier and more modular.