Support type to select in ListBox, Menu, and SideNav#261
Merged
devongovett merged 2 commits intomasterfrom Mar 11, 2020
Merged
Conversation
|
Build successful! 🎉 |
dannify
approved these changes
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for type to select to our collection components, which allows users to start typing the name of an option to jump to it. This is supported automatically for simple
<Item>elements with only plain text inside. For complex children, atextValueprop is required on the<Item>to make it support type to select. There's a warning in case the user misses this.For internationalization support, Intl.Collator is used to do the string comparisons. That handles case folding, ignoring of accents, etc. for us.