Skip to content

Omit disallowEmptySelection from props #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 13, 2021
Merged

Omit disallowEmptySelection from props #2652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6b940b
Omit disallowEmptySelection from props
Dec 8, 2021
8fa53a4
Merge branch 'main' into issue-1617-remove-disallowemptyselection-fro…
LFDanLu Dec 9, 2021
9e91754
Merge remote-tracking branch 'upstream/main' into issue-1617-remove-d…
LFDanLu Dec 10, 2021
2dffd8a
Merge branch 'main' into issue-1617-remove-disallowemptyselection-fro…
LFDanLu Dec 10, 2021
54ff60c
Merge branch 'main' into issue-1617-remove-disallowemptyselection-fro…
dannify Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@react-stately/list/src/useSingleSelectListState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {ListState, useListState} from './useListState';
import {Node} from '@react-types/shared';
import {useControlledState} from '@react-stately/utils';

export interface SingleSelectListProps<T> extends CollectionBase<T>, SingleSelection {
export interface SingleSelectListProps<T> extends CollectionBase<T>, Omit<SingleSelection, 'disallowEmptySelection'> {
/** Filter function to generate a filtered list of nodes. */
filter?: (nodes: Iterable<Node<T>>) => Iterable<Node<T>>,
/** @private */
Expand Down
2 changes: 1 addition & 1 deletion packages/@react-types/combobox/src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {AsyncLoadable, CollectionBase, DOMProps, FocusableProps, HelpTextProps,

export type MenuTriggerAction = 'focus' | 'input' | 'manual';

export interface ComboBoxProps<T> extends CollectionBase<T>, SingleSelection, InputBase, TextInputBase, Validation, FocusableProps, LabelableProps, HelpTextProps {
export interface ComboBoxProps<T> extends CollectionBase<T>, Omit<SingleSelection, 'disallowEmptySelection'>, InputBase, TextInputBase, Validation, FocusableProps, LabelableProps, HelpTextProps {
/** The list of ComboBox items (uncontrolled). */
defaultItems?: Iterable<T>,
/** The list of ComboBox items (controlled). */
Expand Down
2 changes: 1 addition & 1 deletion packages/@react-types/select/src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import {
Validation
} from '@react-types/shared';

export interface SelectProps<T> extends CollectionBase<T>, AsyncLoadable, Omit<InputBase, 'isReadOnly'>, Validation, HelpTextProps, LabelableProps, TextInputBase, SingleSelection, FocusableProps {
export interface SelectProps<T> extends CollectionBase<T>, AsyncLoadable, Omit<InputBase, 'isReadOnly'>, Validation, HelpTextProps, LabelableProps, TextInputBase, Omit<SingleSelection, 'disallowEmptySelection'>, FocusableProps {
/** Sets the open state of the menu. */
isOpen?: boolean,
/** Sets the default open state of the menu. */
Expand Down