ActionButton documentation#275
Merged
Merged
Conversation
ross-pfahler
requested review from
dannify,
devongovett and
snowystinger
as code owners
|
Build successful! 🎉 |
LFDanLu
requested changes
Mar 13, 2020
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
just some small changes but otherwise looks good
Comment on lines
+42
to
+50
| /** An icon to display in the ActionButton */ | ||
| icon?: ReactElement, | ||
| /** Whether the ActionButton should be displayed with a [quiet style](https://spectrum.adobe.com/page/action-button/#Quiet) */ | ||
| isQuiet?: boolean, | ||
| /** Whether the ActionButton should be displayed with a [selected state](https://spectrum.adobe.com/page/action-button/#Selected) */ | ||
| isSelected?: boolean, | ||
| /** Whether the ActionButton should be displayed with a [emphasized style](https://spectrum.adobe.com/page/action-button/#Emphasis) */ | ||
| isEmphasized?: boolean, | ||
| /** Whether the ActionButton should be displayed with a [hold icon](https://spectrum.adobe.com/page/action-button/#Hold-icon) */ |
Member
There was a problem hiding this comment.
Missing periods at the end of these descriptions.
I personally like how you added the links to the spectrum docs in the prop types themselves, should we do this for the same types in other component docs? Open to discussion, we should decide as a group to stay consistent
…nto actionbutton-docs
|
Build successful! 🎉 |
snowystinger
approved these changes
Mar 17, 2020
|
Build successful! 🎉 |
|
Build successful! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RSP-1601
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Team: