Skip to content

(RSP-1616) Dialog Docs #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dannify merged 39 commits into from
Apr 14, 2020
Merged

(RSP-1616) Dialog Docs #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
1932ef6
creating dialog docs page and jsdocs to typescript interfaces
ktabors Mar 14, 2020
099f13b
fixing import to fix example
ktabors Mar 16, 2020
8b3128c
copy improvements
ktabors Mar 16, 2020
cb7b936
fixing package.json merge issue
ktabors Mar 17, 2020
8408d84
Merge branch 'dialog_docs_v1' of https://github.com/adobe-private/rea…
LFDanLu Mar 17, 2020
9e84ab5
simplifying the dialog jsdocs and adding lints to future docs
ktabors Mar 17, 2020
f94beeb
saving progress
LFDanLu Mar 18, 2020
206f7d2
dialog jsdocs feedback updates
ktabors Mar 19, 2020
328b578
first draft of dialog docs
LFDanLu Mar 20, 2020
1446b60
Merge branch 'dialog_docs_v1' of https://github.com/adobe-private/rea…
LFDanLu Mar 20, 2020
787bbef
adding stuff for onDismiss
LFDanLu Mar 20, 2020
923b32e
Merge branch 'master' of https://github.com/adobe-private/react-spect…
LFDanLu Mar 24, 2020
dc29ade
update description so it doesn't conflict with ActionDialog too much
LFDanLu Mar 25, 2020
a03da0c
reorganizing so slots are under advanced section
LFDanLu Mar 25, 2020
3ddaf7d
editing some sentences
LFDanLu Mar 25, 2020
4d1cdde
formatting table via css
LFDanLu Mar 25, 2020
3f454b2
Merge branch 'master' of https://github.com/adobe-private/react-spect…
LFDanLu Mar 26, 2020
c4ad1d0
removing image todo for now
LFDanLu Mar 26, 2020
1eb8755
forgot to delete the image folder too
LFDanLu Mar 26, 2020
277c13d
Merge branch 'master' into RSP-1616
LFDanLu Mar 26, 2020
75c6a67
addressing review comments partial
LFDanLu Mar 27, 2020
fdd9d5a
Merge branch 'master' into RSP-1616
LFDanLu Mar 27, 2020
2560566
adding anatomy svg
LFDanLu Mar 30, 2020
7492dbe
make ExampleImage component for rendering svgs or images in docs
LFDanLu Mar 30, 2020
b667ec7
Merge branch 'master' of https://github.com/adobe-private/react-spect…
LFDanLu Mar 30, 2020
355a484
Updating examples for header/heading update
LFDanLu Mar 30, 2020
b7184ca
Merge branch 'master' into RSP-1616
LFDanLu Mar 30, 2020
2bd4326
Merge branch 'master' of https://github.com/adobe-private/react-spect…
LFDanLu Mar 31, 2020
c0a38f4
readding slots to types due to Dialog structure change
LFDanLu Mar 31, 2020
2473947
Merge branch 'master' of https://github.com/adobe-private/react-spect…
LFDanLu Apr 6, 2020
e4520bb
Updating docs to match updates
LFDanLu Apr 6, 2020
e258f2a
Adding popover/tray examples and fixing docs link
LFDanLu Apr 7, 2020
9e4ba2b
addressing review comments
LFDanLu Apr 7, 2020
d4d9973
Merge branch 'master' into RSP-1616
LFDanLu Apr 9, 2020
7e6fff4
addressing review comments
LFDanLu Apr 14, 2020
4a9922b
forgot to save this last change
LFDanLu Apr 14, 2020
5fc1208
Merge branch 'master' into RSP-1616
LFDanLu Apr 14, 2020
7b0d8b6
fixing lint
LFDanLu Apr 14, 2020
7d56943
Merge branch 'RSP-1616' of https://github.com/adobe-private/react-spe…
LFDanLu Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .parcelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"transforms": {
"docs:*.{js,ts,tsx,json}": ["parcel-transformer-docs", "@parcel/transformer-inline"],
"docs-json:*.{js,ts,tsx,json}": ["parcel-transformer-docs"],
"*.mdx": ["parcel-transformer-mdx-docs"]
"*.mdx": ["parcel-transformer-mdx-docs"],
"*.svg": ["@parcel/transformer-svg-react"]
Copy link
Member Author

@LFDanLu LFDanLu Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was having trouble importing svgs (kept complaining about missing a transformer), stumbled upon this solution. Lemme know if an alternate route should be taken here

},
"namers": ["parcel-namer-docs", "..."],
"packagers": {
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
"@parcel/babel-plugin-transform-runtime": "^2.0.0-nightly.1823",
"@parcel/babel-preset-env": "^2.0.0-nightly.92",
"@parcel/transformer-inline": "^2.0.0-nightly.92",
"@parcel/transformer-svg-react": "^2.0.0-nightly.1739",
"@spectrum-css/vars": "^2.0.0",
"@storybook/addon-a11y": "^5.2.1",
"@storybook/addon-actions": "^5.2.1",
Expand Down
Loading