Skip to content

Remove transition duration prop from ListView#3093

Merged
LFDanLu merged 4 commits intomainfrom
remove_transition_duration
May 3, 2022
Merged

Remove transition duration prop from ListView#3093
LFDanLu merged 4 commits intomainfrom
remove_transition_duration

Conversation

@LFDanLu
Copy link
Copy Markdown
Member

@LFDanLu LFDanLu commented May 3, 2022

Original PR was reverted, only merge after release

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

ListView should have animations when loading in new content, removing content, and when checkboxes are added after long press in highlight selection mode w/ onAction.

🧢 Your Project:

RSP

@LFDanLu LFDanLu changed the title Remove transition duration Remove transition duration prop from ListView May 3, 2022
@LFDanLu
Copy link
Copy Markdown
Member Author

LFDanLu commented May 3, 2022

DNM until after release

Copy link
Copy Markdown
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approval for after release

@adobe-bot
Copy link
Copy Markdown

Build successful! 🎉

@LFDanLu LFDanLu merged commit 3d54d97 into main May 3, 2022
@LFDanLu LFDanLu deleted the remove_transition_duration branch May 3, 2022 23:40
@snowystinger snowystinger mentioned this pull request May 4, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants