Merged
Conversation
|
Build successful! 🎉 |
reidbarber
reviewed
May 26, 2022
Member
reidbarber
left a comment
reidbarber
left a comment
There was a problem hiding this comment.
should we select anything if all tabs are disabled? should it display anything in the tab panel?
Since a disabled tab can be in a selected state (via controlled or default), I think this is fine.
reidbarber
approved these changes
May 26, 2022
LFDanLu
approved these changes
May 26, 2022
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
LGTM, I agree, we should default to selecting the first tab even if it is disabled if all other are disabled. If someone doesn't want to render the TabPanel contents or the Tabs at all for this case, they can do so manually
|
Build successful! 🎉 |
|
Build successful! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Found in testing session
One outstanding question, should we select anything if all tabs are disabled? should it display anything in the tab panel? This PR gets us back to the state we had before which was yes to both of those questions, but I don't feel like we adequately considered this back when we implemented it.
✅ Pull Request Checklist:
📝 Test Instructions:
Load up the story
/story/tabs--all-disabledit should render, the first tab should be selected, focus should go immediately to the tab panel
unit tests should cover the cases
🧢 Your Project: