Skip to content

fix check api script#3169

Merged
snowystinger merged 4 commits into
mainfrom
audit-types-for-release
Jun 10, 2022
Merged

fix check api script#3169
snowystinger merged 4 commits into
mainfrom
audit-types-for-release

Conversation

@snowystinger
Copy link
Copy Markdown
Member

@snowystinger snowystinger commented May 27, 2022

Closes

This dereferences symlinks so that we can copy node_modules, which yarn will link sometimes, shouldn't affect types because it just makes a copy of the file

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger
Copy link
Copy Markdown
Member Author

ok, lint failed because the private packages are deps of public ones... but they should be private until they are released

will undo the field addition and it can be done manually when we run into this again

@adobe-bot
Copy link
Copy Markdown

@snowystinger snowystinger added the small review Easy to review PR label Jun 6, 2022
@adobe-bot
Copy link
Copy Markdown

@snowystinger snowystinger merged commit 9f7ebe4 into main Jun 10, 2022
@snowystinger snowystinger deleted the audit-types-for-release branch June 10, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small review Easy to review PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants