Conversation
|
Build successful! 🎉 |
| export default meta; | ||
|
|
||
| export const NameMe: ViewStory = { | ||
| render: () => ( |
There was a problem hiding this comment.
I think we can probably completely get rid of all stories for view and only have chromatic ones, if we want to keep any View ones, we can add some controls
There was a problem hiding this comment.
How I would do your suggestion is to move both stories over to chromatic and not have any storybook stories. These two stories seemed to test passing in cacl() and special strings for width.
I looked at all the props and there were a ton that were mostly formatting related, I didn't want to do argTypes on that many. It seemed like a lot of work for not much return. I could see creating a single story with a number of these props and have Storybook autogenerate controls.
|
Build successful! 🎉 |
|
Build successful! 🎉 |
| } | ||
| }; | ||
|
|
||
| export const OneOfEachPropGroup: ViewStory = { |
There was a problem hiding this comment.
I added this story because it touches at least one prop from every group. It's the result of me thinking about what a story with controls might look like.
Co-authored-by: Robert Snow <rsnow@adobe.com>
|
Build successful! 🎉 |
|
Build successful! 🎉 |
4 participants
Part of the Storybook CSF 3.0 migration in issue 3056.
Didn't see the need to add any controls to this.
✅ Pull Request Checklist:
📝 Test Instructions:
Kept the existing two view stories.
The second one has a couple auto-generated controls
🧢 Your Project:
RSP