Skip to content

NumberField onChange before onBlur #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snowystinger merged 4 commits into from
Jun 27, 2022
Merged

NumberField onChange before onBlur #3207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e04d81
NumberField onChange before onBlur
snowystinger Jun 9, 2022
967c718
Merge branch 'main' into numberfield-order-of-events
LFDanLu Jun 9, 2022
d27c521
Merge branch 'main' into numberfield-order-of-events
snowystinger Jun 27, 2022
a715591
Merge branch 'main' into numberfield-order-of-events
snowystinger Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@react-aria/numberfield/src/useNumberField.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export function useNumberField(props: AriaNumberFieldProps, state: NumberFieldSt
validationState,
label,
formatOptions,
onBlur,
onBlur = () => {},
onFocus,
onFocusChange,
onKeyDown,
Expand Down Expand Up @@ -204,8 +204,8 @@ export function useNumberField(props: AriaNumberFieldProps, state: NumberFieldSt

let inputProps = mergeProps(
spinButtonProps,
textFieldProps,
focusProps,
textFieldProps,
{
// override the spinbutton role, we can't focus a spin button with VO
role: null,
Expand Down
13 changes: 12 additions & 1 deletion packages/@react-spectrum/numberfield/test/NumberField.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ describe('NumberField', function () {
let onKeyUpSpy = jest.fn();

beforeAll(() => {
jest.useFakeTimers('legacy');
jest.useFakeTimers();
});

afterAll(() => {
Expand Down Expand Up @@ -283,6 +283,17 @@ describe('NumberField', function () {
expect(onBlurSpy).toHaveBeenCalledTimes(2); // blur spy is called after each blur
});

it.each`
Name
${'NumberField'}
`('$Name fires state change then blur', () => {
let {textField} = renderNumberField({onChange: onChangeSpy, onBlur: onBlurSpy, step: 5});
act(() => {textField.focus();});
typeText(textField, '3');
userEvent.tab();
expect(onChangeSpy.mock.invocationCallOrder[0]).toBeLessThan(onBlurSpy.mock.invocationCallOrder[0]);
});

it.each`
Name
${'NumberField'}
Expand Down