Conversation
|
Build successful! 🎉 |
devongovett
approved these changes
Jun 13, 2022
Member
devongovett
left a comment
devongovett
left a comment
There was a problem hiding this comment.
lgtm, tested on iOS and Firefox/Safari/Chrome Mac.
ktabors
reviewed
Jun 13, 2022
Member
ktabors
left a comment
ktabors
left a comment
There was a problem hiding this comment.
LGTM - lest iPad iOS v14 and iPhone iOS v15 and Firefox MacOS
ktabors
approved these changes
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Remove a prevent default that wasn't working to prevent Android text selection of segment and context menu.
Also fixes iOS because pointer-events none is necessary (DatePicker with TimeField in a tray)
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: