-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix focus behavior after dropping ListView item #3369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+461
−7
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
69226c4
Fix focus after dropping item
reidbarber 08bd91f
add tests
reidbarber b52c556
Merge branch 'main' into focus-after-drop
reidbarber dcdee3b
add drag utility
reidbarber 64950b0
fix touch event in drag function
reidbarber a936d9a
fix test
reidbarber bcefff7
update mouse drag tests
reidbarber d368a29
rename drag utility
reidbarber db3a91e
test fixes
reidbarber 37e97b7
Merge branch 'main' into focus-after-drop
reidbarber dbe21f0
more test fixes
reidbarber 4ad0788
fix some tests
reidbarber 134cf7a
update dragAndDrop utility
reidbarber 836b2f4
fix more tests
reidbarber 9a13ae4
fix more tests
reidbarber cbb8324
Merge branch 'main' into focus-after-drop
reidbarber 1ad5b3b
revert dragAndDrop utility add
reidbarber b06b08f
lint
reidbarber 8d108da
lint
reidbarber d8541cb
lint
reidbarber b3666c7
update todos
reidbarber ee3a07c
fix tests
snowystinger c75965c
Merge branch 'main' into focus-after-drop
reidbarber 311246d
fix 16 and 17 tests
snowystinger 347e475
Merge branch 'main' into focus-after-drop
LFDanLu d412972
Merge branch 'main' into focus-after-drop
reidbarber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanna double check, but the
bluris strictly for the original drag target (e.g. the row) and thefocusoutis for the benefit of the Virtualizer'sonBlur?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly