Skip to content

RSP-1639: AlertDialog prop updates for buttons#340

Merged
dannify merged 3 commits intomasterfrom
RSP-1639
Apr 3, 2020
Merged

RSP-1639: AlertDialog prop updates for buttons#340
dannify merged 3 commits intomasterfrom
RSP-1639

Conversation

@pst67662
Copy link
Copy Markdown
Contributor

@pst67662 pst67662 commented Apr 1, 2020

New prop names for button labels
primaryActionLabel
secondaryActionLabel

Make two separate event handlers to replace onConfirm:

onPrimaryAction
onSecondaryAction

✅ Pull Request Checklist:

  • Included link to corresponding Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Team:

@adobe-bot
Copy link
Copy Markdown

Build successful! 🎉

@adobe-bot
Copy link
Copy Markdown

Build successful! 🎉

@adobe-bot
Copy link
Copy Markdown

Build successful! 🎉

@dannify dannify merged commit 9718157 into master Apr 3, 2020
@dannify dannify deleted the RSP-1639 branch April 3, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants