Skip to content

Fix labeled value chromatic stories #3510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
snowystinger merged 2 commits into from
Sep 14, 2022
Merged

Fix labeled value chromatic stories #3510

snowystinger merged 2 commits into from
Sep 14, 2022

Conversation

@snowystinger
Copy link
Member

@snowystinger snowystinger commented Sep 13, 2022

Closes
no value meant the chromatic stories weren't showing anything meaningful

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@adobe-bot
Copy link

adobe-bot commented Sep 13, 2022

Build successful! 🎉

@adobe-bot
Copy link

adobe-bot commented Sep 14, 2022

Build successful! 🎉

@snowystinger snowystinger merged commit e514827 into main Sep 14, 2022
@snowystinger snowystinger deleted the fix-chromatic-stories branch September 14, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devongovett devongovett devongovett approved these changes

@ktabors ktabors ktabors approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@snowystinger @adobe-bot @devongovett @ktabors