Merged
Conversation
LFDanLu
reviewed
Sep 28, 2022
| * Handler that is called after a valid drag is held over the drop target for a period of time. | ||
| * @private | ||
| **/ | ||
| // onDropActivate?: (e: DroppableCollectionActivateEvent) => void, |
Member
There was a problem hiding this comment.
Think you didn't mean to comment this out since you marked it private instead?
Suggested change
| // onDropActivate?: (e: DroppableCollectionActivateEvent) => void, | |
| onDropActivate?: (e: DroppableCollectionActivateEvent) => void, |
Member
Author
There was a problem hiding this comment.
which do we prefer?
Member
Author
There was a problem hiding this comment.
k, private gets rid of the TS errors. do we need to stop using this prop internally though? or is it ok to stay?
Member
There was a problem hiding this comment.
IMO we can keep it for now, so long as the other dnd hooks have it marked as private as well (think useDrop needs to hide it as well).
|
Build successful! 🎉 |
devongovett
reviewed
Sep 28, 2022
| /** Handler that is called after a valid drag is held over the drop target for a period of time. */ | ||
| /** | ||
| * Handler that is called after a valid drag is held over the drop target for a period of time. | ||
| * @private |
Member
There was a problem hiding this comment.
Can you do the same in useDrop?
|
Build successful! 🎉 |
|
Build successful! 🎉 |
devongovett
approved these changes
Sep 29, 2022
|
Build successful! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: