Merged
Conversation
|
Build successful! 🎉 |
snowystinger
reviewed
Apr 3, 2020
|
|
||
| export function UIIcon(props: IconProps) { | ||
| props = useSlotProps(props, 'uiIcon'); | ||
| props = useSlotProps(props, 'icon'); |
Member
There was a problem hiding this comment.
ui icon and icon default to slot icon?
should ui icon have a default?
snowystinger
previously approved these changes
Apr 3, 2020
dannify
approved these changes
Apr 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
slotprop from everything except "content" components (typography, icon, image, etc.). A few additional "container" components can receive slot props from context but not have a custom slot name (e.g. header, footer, content) - they have a default slot name derived from the component name.In addition, this separates
<SlotProvider>from<Grid>and<Flex>so the layout components can be used without providing slots.