Skip to content

Conversation

@LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Feb 28, 2023

Closes #4132

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Go to the Tabs docs. Confirm the page doesn't automatically scroll to the bottom of the page.
Sanity check non-virtualized collection components (aka useSelect story or any of the hooks components that don't have virtualized lists)

🧢 Your Project:

RSP

@LFDanLu LFDanLu added the small review Easy to review PR label Feb 28, 2023
@rspbot
Copy link

rspbot commented Feb 28, 2023

majornista
majornista previously approved these changes Mar 1, 2023
Copy link
Collaborator

@majornista majornista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also verified using the Storybook Tabs examples with scrolling set to true:

Notice how the Tabs are not scrolled into view for each Storybook example with scrolling=true.

For comparison here is the same example using the v3.25.0 release:

Notice how the Tabs are scrolled into view for each Storybook example with scrolling=true.

reidbarber
reidbarber previously approved these changes Mar 1, 2023
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified behavior in docs and storybook

snowystinger
snowystinger previously approved these changes Mar 2, 2023
@LFDanLu LFDanLu dismissed stale reviews from snowystinger, reidbarber, and majornista via a29de31 March 2, 2023 20:30
Co-authored-by: Devon Govett <devongovett@gmail.com>
@rspbot
Copy link

rspbot commented Mar 2, 2023

@rspbot
Copy link

rspbot commented Mar 2, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@devongovett devongovett merged commit 00787b0 into main Mar 2, 2023
@devongovett devongovett deleted the fix_autoscroll branch March 2, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small review Easy to review PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tabs component is automatically scrolled into view on page load

7 participants