-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Prevent autoscrolling of focused collection elements when focus isn't in the non virtualized collection #4133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Build successful! 🎉 |
majornista
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also verified using the Storybook Tabs examples with scrolling set to true:
Notice how the Tabs are not scrolled into view for each Storybook example with scrolling=true.
For comparison here is the same example using the v3.25.0 release:
Notice how the Tabs are scrolled into view for each Storybook example with scrolling=true.
reidbarber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, verified behavior in docs and storybook
a29de31
Co-authored-by: Devon Govett <devongovett@gmail.com>
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
Closes #4132
✅ Pull Request Checklist:
📝 Test Instructions:
Go to the Tabs docs. Confirm the page doesn't automatically scroll to the bottom of the page.
Sanity check non-virtualized collection components (aka useSelect story or any of the hooks components that don't have virtualized lists)
🧢 Your Project:
RSP