Skip to content

React strictmode use value effect#4147

Merged
snowystinger merged 9 commits into
mainfrom
react-strictmode-useValueEffect
Apr 26, 2023
Merged

React strictmode use value effect#4147
snowystinger merged 9 commits into
mainfrom
react-strictmode-useValueEffect

Conversation

@snowystinger
Copy link
Copy Markdown
Member

@snowystinger snowystinger commented Mar 2, 2023

Closes

Note on tests, failure count may be inaccurate due to cascading failures
Before
Test Suites: 27 failed, 1 skipped, 144 passed, 171 of 172 total
Tests: 657 failed, 49 skipped, 3534 passed, 4240 total
Snapshots: 1 passed, 1 total

After
Test Suites: 28 failed, 1 skipped, 143 passed, 171 of 172 total
Tests: 662 failed, 49 skipped, 3529 passed, 4240 total
Snapshots: 1 passed, 1 total

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Comment thread packages/@react-aria/utils/src/useValueEffect.ts Outdated
@rspbot
Copy link
Copy Markdown

rspbot commented Mar 3, 2023

Comment thread packages/@react-aria/utils/src/useValueEffect.ts
@rspbot
Copy link
Copy Markdown

rspbot commented Apr 13, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 14, 2023

Copy link
Copy Markdown
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 25, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 25, 2023

Copy link
Copy Markdown
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets take note of which affected components to include in the next testing session: ActionGroup, Breadcrumbs, ButtonGroup, DatePicker, TagGroup. Maybe others that use useId.

@snowystinger
Copy link
Copy Markdown
Member Author

LGTM, lets take note of which affected components to include in the next testing session: ActionGroup, Breadcrumbs, ButtonGroup, DatePicker, TagGroup. Maybe others that use useId.

good call, it's specifically useSlotId

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 26, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 26, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@snowystinger snowystinger merged commit bd89c6a into main Apr 26, 2023
@snowystinger snowystinger deleted the react-strictmode-useValueEffect branch April 26, 2023 19:09
cgood92 pushed a commit to cgood92/react-spectrum that referenced this pull request May 9, 2023
* React StrictMode useValueEffect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants