Skip to content

Create chromatic stories for tags#4243

Merged
snowystinger merged 2 commits intomainfrom
add-chromatic-for-tags
Mar 23, 2023
Merged

Create chromatic stories for tags#4243
snowystinger merged 2 commits intomainfrom
add-chromatic-for-tags

Conversation

@snowystinger
Copy link
Member

Closes

We are nearing release for these components, we should make sure we don't regress as we fix last minute bugs.

This PR is not meant to be exhaustive in chromatic stories. Just get us started
https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=501

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger
Copy link
Member Author

@reidbarber I think I found a bug with RTL rendering, it's wrapping too early in maxRow stories. Is this addressed in your current PR? I can work on a fix for it here if not.

@devongovett
Copy link
Member

Another thing I noticed here is that the number in the "Show all (X)" button doesn't appear to be formatted with an international number formatter. We might need to update the translation strings to account for that: "Show all ({tagCount, number})"

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, bugs to be handled in other PRs

@rspbot
Copy link

rspbot commented Mar 23, 2023

@rspbot
Copy link

rspbot commented Mar 23, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@snowystinger snowystinger merged commit 6131f76 into main Mar 23, 2023
@snowystinger snowystinger deleted the add-chromatic-for-tags branch March 23, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants