Skip to content

fix chromatic accordion#4271

Merged
snowystinger merged 2 commits intomainfrom
accordion-fixes
Mar 29, 2023
Merged

fix chromatic accordion#4271
snowystinger merged 2 commits intomainfrom
accordion-fixes

Conversation

@snowystinger
Copy link
Copy Markdown
Member

@snowystinger snowystinger commented Mar 27, 2023

Closes
Found here https://www.chromatic.com/test?appId=5f0dd5ad2b5fc10022a2e320&id=6421ce82dacf8a735dc70f65

The CSS in this file did not reflect the actual dom structure and since the color should always be the same as the text we can make the previous specificity winner the default and use inherit instead of specifying colors directly for the chevron

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link
Copy Markdown

rspbot commented Mar 27, 2023

Copy link
Copy Markdown
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

@rspbot
Copy link
Copy Markdown

rspbot commented Mar 29, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Mar 29, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@snowystinger snowystinger merged commit 5b5eeb0 into main Mar 29, 2023
@snowystinger snowystinger deleted the accordion-fixes branch March 29, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants