Skip to content

Adding ComboBox and Select render props#4554

Merged
dannify merged 4 commits intomainfrom
adding_renderProps
May 19, 2023
Merged

Adding ComboBox and Select render props#4554
dannify merged 4 commits intomainfrom
adding_renderProps

Conversation

@LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented May 19, 2023

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

@LFDanLu LFDanLu added small review Easy to review PR release labels May 19, 2023
@LFDanLu LFDanLu marked this pull request as ready for review May 19, 2023 20:31
@rspbot
Copy link

rspbot commented May 19, 2023

@rspbot
Copy link

rspbot commented May 19, 2023

@rspbot
Copy link

rspbot commented May 19, 2023

@rspbot
Copy link

rspbot commented May 19, 2023

@rspbot
Copy link

rspbot commented May 19, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@dannify dannify merged commit 1d3e034 into main May 19, 2023
@dannify dannify deleted the adding_renderProps branch May 19, 2023 22:45
@dannify dannify removed the release label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments