Skip to content

Remove extraneous 'all' from Expandable type #4880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LFDanLu merged 2 commits into from
Aug 8, 2023
Merged

Remove extraneous 'all' from Expandable type #4880

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f255db
Remove all from Expandable type
LFDanLu Aug 8, 2023
fa3b5b4
Merge branch 'main' into fix_expandable_type
LFDanLu Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@react-types/shared/src/collections.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ export interface CollectionStateBase<T, C extends Collection<Node<T>> = Collecti

export interface Expandable {
/** The currently expanded keys in the collection (controlled). */
expandedKeys?: 'all' | Iterable<Key>,
expandedKeys?: Iterable<Key>,
/** The initial expanded keys in the collection (uncontrolled). */
defaultExpandedKeys?: 'all' | Iterable<Key>,
defaultExpandedKeys?: Iterable<Key>,
/** Handler that is called when items are expanded or collapsed. */
onExpandedChange?: (keys: Set<Key>) => any
}
Expand Down