Skip to content

Remove erroneous accessibility color contrast ignore rule #5029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LFDanLu merged 2 commits into from
Sep 6, 2023
Merged

Remove erroneous accessibility color contrast ignore rule #5029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d67e4f9
Remove erroneous accessibility color contrast ignore rule
LFDanLu Sep 6, 2023
9587acd
Merge branch 'main' into restore_supressed_warning
LFDanLu Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .storybook/test-runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ module.exports = {
await configureAxe(page, {
// TODO: Ideally would have a selector target for the storybook's sb main body element
rules: [
{
id: 'color-contrast',
selector: 'body *:not([data-a11y-ignore="color-contrast"])'
},
{
id: 'aria-hidden-focus',
selector: 'body *:not([data-a11y-ignore="aria-hidden-focus"])',
Expand Down
3 changes: 1 addition & 2 deletions packages/@react-spectrum/datepicker/src/DatePickerSegment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@ function EditableSegment({segment, state}: DatePickerSegmentProps) {
minWidth: segment.maxValue != null ? String(segment.maxValue).length + 'ch' : null
}}
data-testid={segment.type}>
{/* TODO: double check this, color contrast issue with quiet placeholder */}
<span data-a11y-ignore="color-contrast" aria-hidden="true" className={classNames(styles, 'react-spectrum-DatePicker-placeholder')}>{segment.placeholder}</span>
<span aria-hidden="true" className={classNames(styles, 'react-spectrum-DatePicker-placeholder')}>{segment.placeholder}</span>
{segment.isPlaceholder ? '' : segment.text}
</div>
);
Expand Down