Skip to content

Add selectionMode to Toolbar story#5257

Merged
yihuiliao merged 2 commits intomainfrom
update-toolbar-story
Oct 17, 2023
Merged

Add selectionMode to Toolbar story#5257
yihuiliao merged 2 commits intomainfrom
update-toolbar-story

Conversation

@yihuiliao
Copy link
Member

@yihuiliao yihuiliao commented Oct 16, 2023

Found during testing

Updates the story for Toolbar using actionGroup to use selectionMode so that it's easy to show it working with touch

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Link to Toolbar story

When you select on the items, they should visually appear to be selected.

🧢 Your Project:

@rspbot
Copy link

rspbot commented Oct 16, 2023

@yihuiliao yihuiliao marked this pull request as ready for review October 16, 2023 23:51
@rspbot
Copy link

rspbot commented Oct 17, 2023

@rspbot
Copy link

rspbot commented Oct 17, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@yihuiliao yihuiliao merged commit 876e678 into main Oct 17, 2023
@yihuiliao yihuiliao deleted the update-toolbar-story branch October 17, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants