-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Yarn 4 #6215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yarn 4 #6215
Changes from all commits
c8d672d
859fe6c
d707707
0369b4e
03e51d5
c86e306
40eb43f
dbb5210
0385610
ae9877c
d204587
cee068c
e9eacc5
ef2ccaf
dd0f75f
b4eb9ae
5fa0d98
73598cf
44f0582
4f38f54
62e8dfc
1ed80b2
825a1a6
4ea35a5
d0968cf
79d47ee
16e293e
99bbddc
992dc24
97a0334
b2f558e
46032db
a045a86
78b84fd
71d9a94
3659d3d
85a7422
61b69e9
71a1130
0e4d071
f6a2a71
cf0dc05
85016fa
4f18b20
d19ec04
241a3f4
c0bdffa
03a37fe
305e751
4894126
412cce0
c0dab4c
ec0a4d5
d55c3fe
759a136
fbbba2b
0e96872
c650741
c496951
8bb3435
3c4e271
13c3a27
68ef5ee
5e2498a
9342cf1
fbac033
8fe9f64
2d6d783
e89932e
55d60c1
5ed717c
201cefb
0f9581a
92e28ee
73509c6
85ceb9b
f1c6aa1
9e0a70c
1266307
c7e55de
1941efa
ff46bb9
febceaa
ef89b14
cd06160
ef1226a
210b59f
b90f3ec
925c6d4
7f3d12e
4ed5872
ed816d8
d275b8c
aa374b9
ef46ce8
bb6bc3f
c121a19
1da31f9
9ad651c
d706a4e
be69c0b
b2073ad
d025cc8
83e84d7
cbbe651
40be986
765a28c
ce9512f
b5797a8
09aef19
f94da57
fc777fd
a0ae708
c7cbc87
b611272
65d0450
1ddaf26
6be2ffb
e7fe674
7be3720
b30bda1
c031a09
23a6b42
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| nodeLinker: node-modules | ||
|
|
||
| packageExtensions: | ||
| "@parcel/node-resolver-core@*": | ||
| peerDependencies: | ||
| "@parcel/core": ^2.12.0 | ||
|
|
||
| unsafeHttpWhitelist: | ||
| - localhost | ||
|
|
||
| yarnPath: .yarn/releases/yarn-4.2.2.cjs |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,7 @@ run_chromatic: | |
| clean: | ||
| yarn clean:icons | ||
| rm -rf dist public src/dist | ||
| rm -rf storage | ||
|
|
||
| clean_all: | ||
| $(MAKE) clean | ||
|
|
@@ -26,10 +27,14 @@ clean_node_modules: | |
| rm -rf node_modules | ||
| rm -rf packages/*/*/node_modules | ||
| rm -rf examples/*/node_modules | ||
| rm -rf starters/*/node_modules | ||
|
|
||
| clean_dist: | ||
| rm -rf packages/*/*/dist | ||
| rm -rf packages/{react-aria,react-aria-components,react-stately}/dist | ||
| rm -rf packages/{react-aria,react-aria-components,react-stately}/i18n | ||
| rm -rf packages/@adobe/react-spectrum/i18n | ||
| rm -rf packages/@react-aria/i18n/server | ||
|
|
||
| clean_parcel: | ||
| rm -rf .parcel-cache | ||
|
|
@@ -96,7 +101,7 @@ publish-nightly: build | |
|
|
||
| build: | ||
| parcel build packages/@react-{spectrum,aria,stately}/*/ packages/@internationalized/{message,string,date,number}/ packages/react-aria-components --no-optimize --config .parcelrc-build | ||
| yarn lerna run prepublishOnly | ||
| yarn workspaces foreach --all -pt run prepublishOnly | ||
snowystinger marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| for pkg in packages/@react-{spectrum,aria,stately}/*/ packages/@internationalized/{message,string,date,number}/ packages/@adobe/react-spectrum/ packages/react-aria/ packages/react-stately/ packages/react-aria-components/; \ | ||
| do node scripts/buildEsm.js $$pkg; \ | ||
| done | ||
|
|
@@ -118,7 +123,7 @@ check-examples: | |
|
|
||
| starter: | ||
| node scripts/extractStarter.mjs | ||
| cd starters/docs && yarn && yarn tsc | ||
| cd starters/docs && yarn --no-immutable && yarn tsc | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. by default on CI, yarn install is always immutable. This is important for many of our steps, however, when it comes to our sub projects with no lock files, we don't want that note, all of them now have to have a blank yarn.lock, otherwise yarn4 will try to associate them with workspaces in our monorepo, which we don't want. this is their official stance on it and if you remove a blank one, you'll get an error message explaining you need to include a blank one |
||
|
|
||
| starter-zip: starter | ||
| cp LICENSE starters/docs/. | ||
|
|
@@ -129,7 +134,7 @@ starter-zip: starter | |
|
|
||
| tailwind-starter: | ||
| cp LICENSE starters/tailwind/. | ||
| cd starters/tailwind && yarn && yarn tsc | ||
| cd starters/tailwind && yarn --no-immutable && yarn tsc | ||
| cd starters/tailwind && zip -r react-aria-tailwind-starter.zip . -x .gitignore .DS_Store "node_modules/*" "storybook-static/*" | ||
| mv starters/tailwind/react-aria-tailwind-starter.zip dist/production/docs/react-aria-tailwind-starter.$$(git rev-parse --short HEAD).zip | ||
| cd starters/tailwind && yarn build-storybook | ||
|
|
||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| nodeLinker: node-modules | ||
|
|
||
| yarnPath: .yarn/releases/yarn-4.2.2.cjs |
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| nodeLinker: node-modules | ||
|
|
||
| yarnPath: .yarn/releases/yarn-4.2.2.cjs |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,17 @@ | ||
| { | ||
| "name": "rac-spectrum-tailwind-example", | ||
| "private": true, | ||
| "packageManager": "yarn@4.2.2", | ||
| "scripts": { | ||
| "start": "parcel src/index.html", | ||
| "build": "parcel build src/index.html", | ||
| "install-17": "yarn add -W react@^17 react-dom@^17" | ||
| }, | ||
| "dependencies": { | ||
| "@adobe/react-spectrum": "^3.28.0", | ||
| "@react-spectrum/provider": "^3.9.7", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. where did this direct dependency come from?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I noticed a couple packages had a specific minimum range, so I figured this was a good idea to just always update like the rest of our dependencies |
||
| "@spectrum-icons/illustrations": "^3.6.3", | ||
| "@spectrum-icons/workflow": "^4.2.2", | ||
| "@spectrum-icons/workflow": "^4.2.12", | ||
| "parcel": "2.0.0-dev.1599", | ||
| "postcss": "^8.2.1", | ||
| "react": "^18.2.0", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cache is checked into github right now, but we could change the caching strategy. This is the recommended one though
https://yarnpkg.com/features/caching
New recommendations will come eventually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait is the cache being checked in? I thought there would be something in
.yarn/cachehere but I don't see that in this PR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, looks like i went back on this due to size
I think we can discuss if we want to do this or not
right now, the install time on CI has stayed roughly the same (technically it's a little faster than it used to be) so that's why I left off the manual caching we were doing previously
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh interesting that the install time is roughly the same as before even without the caching, I'm fine with not caching then