Skip to content

chore: test for time conversion edge case and fuzzy test numeral systems #7384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snowystinger merged 3 commits into from
Nov 18, 2024
Merged

chore: test for time conversion edge case and fuzzy test numeral systems #7384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c617e93
chore: add test for time conversion edge case
snowystinger Nov 17, 2024
31e2137
add numeral systems to our fuzzy checker
snowystinger Nov 17, 2024
d703eac
lint
reidbarber Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/@internationalized/date/tests/conversion.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@ describe('CalendarDate conversion', function () {
it('should convert a date from absolute in the BC era', function () {
let date = fromAbsolute(new Date('0000-01-01T00:00:00.000Z').getTime(), 'UTC');
expect(date).toEqual(new ZonedDateTime('BC', 1, 1, 1, 'UTC', 0, 0, 0, 0));
date = fromAbsolute(new Date('0001-01-01T00:00:00.000Z').getTime(), 'UTC');
expect(date).toEqual(new ZonedDateTime('AD', 1, 1, 1, 'UTC', 0, 0, 0, 0));

date = fromAbsolute(new Date('-000009-01-01T00:00:00.000Z').getTime(), 'UTC');
expect(date).toEqual(new ZonedDateTime('BC', 10, 1, 1, 'UTC', 0, 0, 0, 0));
Expand Down
22 changes: 12 additions & 10 deletions packages/@internationalized/number/test/NumberParser.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,11 @@ describe('NumberParser', function () {
});

describe('round trips', function () {
fc.configureGlobal({numRuns: 200});
// Locales have to include: 'de-DE', 'ar-EG', 'fr-FR' and possibly others
// But for the moment they are not properly supported
const localesArb = fc.constantFrom(...locales);
const numeralArb = fc.constantFrom('latn', 'arab', 'hanidec', 'deva', 'beng');
const styleOptsArb = fc.oneof(
{withCrossShrink: true},
fc.record({style: fc.constant('decimal')}),
Expand Down Expand Up @@ -210,35 +212,35 @@ describe('NumberParser', function () {
fc.double({next: true, noNaN: true, min: DOUBLE_MIN, max: 1 / DOUBLE_MIN})
).map(([sign, value]) => sign * value);

const inputsArb = fc.tuple(valueArb, localesArb, styleOptsArb, genericOptsArb)
.map(([d, locale, styleOpts, genericOpts]) => ({d, opts: {...styleOpts, ...genericOpts}, locale}))
const inputsArb = fc.tuple(valueArb, localesArb, styleOptsArb, genericOptsArb, numeralArb)
.map(([d, locale, styleOpts, genericOpts, numerals]) => ({d, opts: {...styleOpts, ...genericOpts}, locale, numerals}))
.filter(({opts}) => opts.minimumFractionDigits === undefined || opts.maximumFractionDigits === undefined || opts.minimumFractionDigits <= opts.maximumFractionDigits)
.filter(({opts}) => opts.minimumSignificantDigits === undefined || opts.maximumSignificantDigits === undefined || opts.minimumSignificantDigits <= opts.maximumSignificantDigits)
.map(({d, opts, locale}) => {
.map(({d, opts, locale, numerals}) => {
if (opts.style === 'percent') {
opts.minimumFractionDigits = opts.minimumFractionDigits > 18 ? 18 : opts.minimumFractionDigits;
opts.maximumFractionDigits = opts.maximumFractionDigits > 18 ? 18 : opts.maximumFractionDigits;
}
return {d, opts, locale};
return {d, opts, locale, numerals};
})
.map(({d, opts, locale}) => {
.map(({d, opts, locale, numerals}) => {
let adjustedNumberForFractions = d;
if (Math.abs(d) < 1 && opts.minimumFractionDigits && opts.minimumFractionDigits > 1) {
adjustedNumberForFractions = d * (10 ** (opts.minimumFractionDigits || 2));
} else if (Math.abs(d) > 1 && opts.minimumFractionDigits && opts.minimumFractionDigits > 1) {
adjustedNumberForFractions = d / (10 ** (opts.minimumFractionDigits || 2));
}
return {adjustedNumberForFractions, opts, locale};
return {adjustedNumberForFractions, opts, locale, numerals};
});

// skipping until we can reliably run it, until then, it's good to run manually
// track counter examples below
it.skip('should fully reverse NumberFormat', function () {
it('should fully reverse NumberFormat', function () {
fc.assert(
fc.property(
inputsArb,
function ({adjustedNumberForFractions, locale, opts}) {
const formatter = new Intl.NumberFormat(locale, opts);
function ({adjustedNumberForFractions, locale, opts, numerals}) {
const formatter = new Intl.NumberFormat(`${locale}-u-nu-${numerals}`, opts);
const parser = new NumberParser(locale, opts);

const formattedOnce = formatter.format(adjustedNumberForFractions);
Expand All @@ -264,7 +266,7 @@ describe('NumberParser', function () {
expect(formatter.format(parser.parse(formattedOnce))).toBe(formattedOnce);
});
// See Bug https://github.com/nodejs/node/issues/49919
it.skip('formatted units keep their number', () => {
it('formatted units keep their number', () => {
let locale = 'da-DK';
let options = {
style: 'unit',
Expand Down