fix: Chromatic/testing found bugs #7819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbarber
previously approved these changes
Feb 24, 2025
snowystinger
changed the title
snowystinger
commented
Feb 25, 2025
| ...rectStyles | ||
| }; | ||
|
|
||
| if (layoutInfo.isSticky && !parent?.allowOverflow) { |
Member
Author
There was a problem hiding this comment.
haven't found any place that this code was affecting other than to make our S2 Tables empty and spinners not centered
devongovett
reviewed
Feb 25, 2025
devongovett
reviewed
Feb 25, 2025
devongovett
reviewed
Feb 25, 2025
devongovett
reviewed
Feb 25, 2025
## API Changes
react-aria-components/react-aria-components:Autocomplete Autocomplete {
children: ReactNode
defaultInputValue?: string
- disableAutoFocusFirst?: boolean = false
filter?: (string, string) => boolean
inputValue?: string
onInputChange?: (string) => void
slot?: string | null/react-aria-components:AutocompleteProps AutocompleteProps {
children: ReactNode
defaultInputValue?: string
- disableAutoFocusFirst?: boolean = false
filter?: (string, string) => boolean
inputValue?: string
onInputChange?: (string) => void
slot?: string | null@react-aria/autocomplete/@react-aria/autocomplete:AriaAutocompleteProps AriaAutocompleteProps {
children: ReactNode
defaultInputValue?: string
- disableAutoFocusFirst?: boolean = false
filter?: (string, string) => boolean
inputValue?: string
onInputChange?: (string) => void
}/@react-aria/autocomplete:AriaAutocompleteOptions AriaAutocompleteOptions {
collectionRef: RefObject<HTMLElement | null>
defaultInputValue?: string
- disableAutoFocusFirst?: boolean = false
filter?: (string, string) => boolean
inputRef: RefObject<HTMLInputElement | null>
inputValue?: string
onInputChange?: (string) => void@react-spectrum/s2/@react-spectrum/s2:TreeViewItem-TreeViewItem <T extends {}> {
+TreeViewItem {
aria-label?: string
- childItems?: Iterable<{}>
children: ReactNode
download?: boolean | string
hasChildItems?: boolean
href?: Href
id?: Key
isDisabled?: boolean
onAction?: () => void
onHoverChange?: (boolean) => void
onHoverEnd?: (HoverEvent) => void
onHoverStart?: (HoverEvent) => void
ping?: string
referrerPolicy?: HTMLAttributeReferrerPolicy
rel?: string
routerOptions?: RouterOptions
target?: HTMLAttributeAnchorTarget
textValue: string
value?: T
}/@react-spectrum/s2:TreeViewItemProps-TreeViewItemProps <T extends {} = {}> {
+TreeViewItemProps {
aria-label?: string
- childItems?: Iterable<{}>
children: ReactNode
download?: boolean | string
hasChildItems?: boolean
href?: Href
id?: Key
isDisabled?: boolean
onAction?: () => void
onHoverChange?: (boolean) => void
onHoverEnd?: (HoverEvent) => void
onHoverStart?: (HoverEvent) => void
ping?: string
referrerPolicy?: HTMLAttributeReferrerPolicy
rel?: string
routerOptions?: RouterOptions
target?: HTMLAttributeAnchorTarget
textValue: string
value?: T
}@react-spectrum/style-macro-s1/@react-spectrum/style-macro-s1:focusRing+focusRing {
+ returnVal: undefined
+}@react-spectrum/tree/@react-spectrum/tree:TreeViewItem-TreeViewItem <T extends {}> {
+TreeViewItem {
aria-label?: string
- childItems?: Iterable<{}>
children: ReactNode
download?: boolean | string
hasChildItems?: boolean
href?: Href
id?: Key
isDisabled?: boolean
onAction?: () => void
ping?: string
referrerPolicy?: HTMLAttributeReferrerPolicy
rel?: string
routerOptions?: RouterOptions
target?: HTMLAttributeAnchorTarget
textValue: string
}/@react-spectrum/tree:SpectrumTreeViewItemProps-SpectrumTreeViewItemProps <T extends {} = {}> {
+SpectrumTreeViewItemProps {
aria-label?: string
- childItems?: Iterable<{}>
children: ReactNode
download?: boolean | string
hasChildItems?: boolean
href?: Href
id?: Key
isDisabled?: boolean
onAction?: () => void
ping?: string
referrerPolicy?: HTMLAttributeReferrerPolicy
rel?: string
routerOptions?: RouterOptions
target?: HTMLAttributeAnchorTarget
textValue: string
} |
yihuiliao
approved these changes
Feb 26, 2025
LFDanLu
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
See bugs here https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=907
Summary:
Other issues from testing
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: