fix: ensure that class names produced by S2 style macro differs for each theme #7822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhovhannes
commented
Feb 24, 2025
| "@layer _.a, _.b; | ||
| @layer _.a { | ||
| .chc_2c { |
There was a problem hiding this comment.
chc here is the hash of 0.6.0 read from package.json. I pushed this test just to illustrate how my changes affect produced CSS.
bhovhannes
force-pushed
the
main-hb-fix-style-macro-theme-clashes
branch
2 times, most recently
from
4ce10e1 to
8ea8919
Compare
…fferent S2 themes
bhovhannes
force-pushed
the
main-hb-fix-style-macro-theme-clashes
branch
from
8ea8919 to
6cb905c
Compare
|
Closing this for now. I'll be working on a different approach in the coming sprint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: