Skip to content

Conversation

@Persists
Copy link
Contributor

Found During Testing

The CalendarCell component was missing the readonly attributes; this PR adds those.

Changes:

  • Adjusted the useCalendarCell hook.
  • Updated the RAC component to apply:
    • data-readonly on the button within the grid cell.
    • aria-readonly on the grid cell element.
  • Added a test

Let me know if there are any further adjustments needed 😃

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@Persists Persists changed the title add: readonly for CalendarCell add: readonly attributes for CalendarCell Apr 10, 2025
@Persists
Copy link
Contributor Author

The data-readonly attribute is currently also missing on the Calendar and RangeCalendar components. I can include it in this PR as well.

@yihuiliao
Copy link
Member

Did you have a specific use case where this came up? I think it might be weird to be able to make only some cells isReadOnly.

@snowystinger snowystinger added the waiting Waiting on Issue Author label Aug 4, 2025
@yihuiliao
Copy link
Member

Closing due to inactivity. Happy to revisit this if we can get additional info on the use case!

@yihuiliao yihuiliao closed this Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting Waiting on Issue Author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants