Skip to content

Conversation

@kylemh
Copy link
Contributor

@kylemh kylemh commented Aug 21, 2025

Closes #8687

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

None, unit test should suffice here

@snowystinger snowystinger merged commit 788773e into adobe:main Aug 21, 2025
30 of 31 checks passed
@snowystinger
Copy link
Member

I have no idea why that merged, I am so sorry. I've reverted it and will reopen it for review.

@snowystinger
Copy link
Member

I've opened it here #8756
Thank you for starting it.
Nice thing about this is that we'll get our Typescript API diff checking at least. Sorry for any confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot set aria-disabled on Button component

2 participants