fix: add placeholder to starter app Textfield types #9069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
previously approved these changes
Oct 20, 2025
starters/docs/src/TextField.tsx
Outdated
| <AriaTextField {...props}> | ||
| <Label>{label}</Label> | ||
| <Input className="react-aria-Input inset" /> | ||
| <Input className="react-aria-Input inset" placeholder='' /> |
Member
There was a problem hiding this comment.
do we need this in the tailwind starter as well?
Member
There was a problem hiding this comment.
shouldn't it pass through the placeholder rather than an empty string?
reidbarber
previously approved these changes
Oct 20, 2025
starters/docs/src/TextField.tsx
Outdated
| <AriaTextField {...props}> | ||
| <Label>{label}</Label> | ||
| <Input className="react-aria-Input inset" /> | ||
| <Input className="react-aria-Input inset" placeholder='' /> |
Member
There was a problem hiding this comment.
Would it better to pass it through, but default it as empty string?
|
Build successful! 🎉 |
devongovett
approved these changes
Oct 20, 2025
reidbarber
approved these changes
Oct 20, 2025
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build failure
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP