Skip to content

fix: properly handle 0 as row ID #9087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

fix: properly handle 0 as row ID #9087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b37ff38
fix: properly handle 0 as row ID
chirokas Oct 23, 2025
ce8175f
Merge branch 'main' into table-handle-zero-row-id
snowystinger Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@react-aria/collections/src/CollectionBuilder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ const CollectionContext = createContext<CachedChildrenOptions<unknown> | null>(n
export function Collection<T extends object>(props: CollectionProps<T>): JSX.Element {
let ctx = useContext(CollectionContext)!;
let dependencies = (ctx?.dependencies || []).concat(props.dependencies);
let idScope = props.idScope || ctx?.idScope;
let idScope = props.idScope ?? ctx?.idScope;
let children = useCollectionChildren({
...props,
idScope,
Expand Down
2 changes: 1 addition & 1 deletion packages/@react-aria/collections/src/useCachedChildren.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export function useCachedChildren<T extends object>(props: CachedChildrenOptions
throw new Error('Could not determine key for item');
}

if (idScope) {
if (idScope != null) {
key = idScope + ':' + key;
}
// Note: only works if wrapped Item passes through id...
Expand Down
10 changes: 5 additions & 5 deletions packages/react-aria-components/stories/Table.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,10 @@ let columns = [
];

let rows = [
{id: 1, name: 'Games', date: '6/7/2020', type: 'File folder'},
{id: 2, name: 'Program Files', date: '4/7/2021', type: 'File folder'},
{id: 3, name: 'bootmgr', date: '11/20/2010', type: 'System file'},
{id: 4, name: 'log.txt', date: '1/18/20167', type: 'Text Document'}
{id: 0, name: 'Games', date: '6/7/2020', type: 'File folder'},
{id: 1, name: 'Program Files', date: '4/7/2021', type: 'File folder'},
{id: 2, name: 'bootmgr', date: '11/20/2010', type: 'System file'},
{id: 3, name: 'log.txt', date: '1/18/20167', type: 'Text Document'}
];

export const TableDynamicExample: TableStory = () => {
Expand All @@ -228,7 +228,7 @@ export const TableDynamicExample: TableStory = () => {
</TableHeader>
<TableBody items={rows}>
{(item) => (
<Row columns={columns}>
<Row columns={columns} id={item.id}>
{(column) => {
return <Cell>{item[column.id]}</Cell>;
}}
Expand Down