Skip to content

Fix docs for composition events #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2020
Merged

Fix docs for composition events #909

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca401a8
Fix docs for composition events
amy-lei Aug 7, 2020
375724d
Merge branch 'main' into fix-docs
amy-lei Aug 7, 2020
4f259df
Merge branch 'main' into fix-docs
snowystinger Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/@react-types/shared/src/dom.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,14 @@ export interface TextInputDOMProps extends DOMProps {

// Composition events
/**
* Handler that is called when a text composition system starts a new text composition session. See [MDN](https://developer.mozilla.org/en-US/docs/Web/API/Element/compositionend_event).
* Handler that is called when a text composition system starts a new text composition session. See [MDN](https://developer.mozilla.org/en-US/docs/Web/API/Element/compositionstart_event).
*/
onCompositionEnd?: CompositionEventHandler<HTMLInputElement>,

onCompositionStart?: CompositionEventHandler<HTMLInputElement>,
/**
* Handler that is called when a text composition system completes or cancels the current text composition session. See [MDN](https://developer.mozilla.org/en-US/docs/Web/API/Element/compositionstart_event).
* Handler that is called when a text composition system completes or cancels the current text composition session. See [MDN](https://developer.mozilla.org/en-US/docs/Web/API/Element/compositionend_event).
*/
onCompositionStart?: CompositionEventHandler<HTMLInputElement>,
onCompositionEnd?: CompositionEventHandler<HTMLInputElement>,

/**
* Handler that is called when a new character is received in the current text composition session. See [MDN](https://developer.mozilla.org/en-US/docs/Web/API/Element/compositionupdate_event).
Expand Down