Skip to content

Conversation

@snowystinger
Copy link
Member

Closes

Fixed locales not working, it involves including every locale though, which defeats the purpose of optimising, but it's the only way to make that one example work

Fixed size of placement control for popover in RAC docs, it takes up a lot of room in mobile though, do we want some sort of container query instead which turns it into a Select instead?

Fixed making DateField scroll, it already was "fixed" via width: content, but this seems more complete and useful.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Nov 16, 2025

@rspbot
Copy link

rspbot commented Nov 18, 2025

gridTemplateColumns: '25px 24px 24px 25px 24px',
gridTemplateRows: '25px 24px 24px 25px 24px'
gridTemplateColumns: 'calc(25px * var(--s2-scale)) calc(24px * var(--s2-scale)) calc(24px * var(--s2-scale)) calc(25px * var(--s2-scale)) calc(24px * var(--s2-scale))',
gridTemplateRows: 'calc(25px * var(--s2-scale)) calc(24px * var(--s2-scale)) calc(24px * var(--s2-scale)) calc(25px * var(--s2-scale)) calc(24px * var(--s2-scale))'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use an array of numbers here and the style macro will do this automatically?

Suggested change
gridTemplateRows: 'calc(25px * var(--s2-scale)) calc(24px * var(--s2-scale)) calc(24px * var(--s2-scale)) calc(25px * var(--s2-scale)) calc(24px * var(--s2-scale))'
gridTemplateRows: [25, 24, 24, 25, 24]

Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll follow up on my comment

@devongovett devongovett added this pull request to the merge queue Nov 21, 2025
Merged via the queue into main with commit 76eb2e7 Nov 21, 2025
32 checks passed
@devongovett devongovett deleted the docs-example-fixes branch November 21, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants