fix(docs): S2 docs search menu view transitions

[reidbarber]

• Fixes Unexpected duplicate view-transition-name error that was thrown when closing the search menu
• Hides the old elements while the new ones are transitioning in

✅ Pull Request Checklist:

• Included link to corresponding React Spectrum GitHub Issue.
• Added/updated unit tests and storybook for this change (for new code or code which already has tests).
• Filled out test instructions.
• Updated documentation (if it already exists for this component).
• Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Open and close the search menu is various browsers.

🧢 Your Project:

[rspbot]

Build successful! 🎉

• View the storybook
• View the S2 storybook
• View the documentation
• View the S2 docs

[LFDanLu]

LGTM, I just noticed the builds have been failing so prob best to get a up to date build link for this PR before it goes in so we can test off that

[rspbot]

Build successful! 🎉

• View the storybook
• View the S2 storybook
• View the documentation
• View the S2 docs

[rspbot]

Build successful! 🎉

• View the storybook
• View the S2 storybook
• View the documentation
• View the S2 docs