docs: Link to imported files in code examples #9197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
snowystinger
previously approved these changes
Nov 18, 2025
LFDanLu
previously approved these changes
Nov 19, 2025
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
LGTM for the most part. I noticed that I couldn't expand the css file under Toolbar.tsx in the RAC toolbar docs even though it was a link. If you open many files, the quiet picker that it switches to is too long but I think we already noted this separately,
Approving anyways if you wanna handle this in a followup, definitely a improvement in the experience IMO
Member
Author
oh I think this is a bug we have in a few components where the code is actually the vanilla css example instead of the tailwind one. must be a copy paste issue. we can fix that separately. |
devongovett
dismissed stale reviews from LFDanLu and snowystinger
via
9ac075a
|
Build successful! 🎉 |
bsmiley1
pushed a commit
to bsmiley1/react-spectrum
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the code examples don't display every file that is needed at once because there'd be way too many tabs and we want to focus on the relevant content. But users might still want to access other files to copy and paste them. This makes imported files in code examples into links to switch tabs. If you click one that isn't already in a tab, a tab will be added to display that file on demand.