Skip to content

docs: S2 docs testing fixes (12/1/25)#9268

Merged
snowystinger merged 9 commits intomainfrom
s2-docs-dec-testing-fixes
Dec 3, 2025
Merged

docs: S2 docs testing fixes (12/1/25)#9268
snowystinger merged 9 commits intomainfrom
s2-docs-dec-testing-fixes

Conversation

@reidbarber
Copy link
Copy Markdown
Member

@reidbarber reidbarber commented Dec 2, 2025 •
edited
Loading

  • sort cards in alphabetically by name (was previously relying on default order)
  • fix asterisk color on props table (now visible in dark mode)
  • fix props table first column wrapping too soon
  • remove testing pages from search results
  • update testing page link names to include component names
  • prevent duplicate ToastContainers on Toast page
  • disable minification of html (fixes hydration error)
  • update label to be aria-label in ProgressCircle example

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link
Copy Markdown

rspbot commented Dec 2, 2025

Build successful! 🎉

snowystinger
snowystinger reviewed Dec 2, 2025
View reviewed changes
Comment thread packages/dev/s2-docs/src/PropTable.tsx
Comment thread packages/dev/s2-docs/src/PropTable.tsx
@reidbarber reidbarber added this pull request to the merge queue Dec 3, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 3, 2025
@snowystinger snowystinger added this pull request to the merge queue Dec 3, 2025
github-merge-queue Bot pushed a commit that referenced this pull request Dec 3, 2025
@reidbarber
docs: S2 docs testing fixes (12/1/25) (#9268)
f89321d 
* sort cards in alphabetically by name

* fix asterisk color on props table

* fix props table first column wrapping

* remove testing pages from search results

* update testing page link names

* prevent duplicate ToastContainers

* try disabling minification of html

* Revert "try disabling minification of html"

This reverts commit da60c7d.

* Revert "Revert "try disabling minification of html""

This reverts commit 0d6015a.
Merged via the queue into main with commit ac02760 Dec 3, 2025
34 checks passed
@snowystinger snowystinger deleted the s2-docs-dec-testing-fixes branch December 3, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devongovett devongovett devongovett approved these changes

@snowystinger snowystinger snowystinger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reidbarber @rspbot @devongovett @snowystinger