-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: collections nested within Activities (React 19.2) #9300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: collections nested within Activities (React 19.2) #9300
Conversation
snowystinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting this. Let's see if we can get the PR checks passing.
You can run lint locally with yarn lint
|
@snowystinger added |
|
@snowystinger thanks for jumping in. Lets get this out! I got most of the CI working but something seems up with the TS scripts... is this a known issue or is this introduced by this PR? |
|
Hm, it looks like the issue is that it is a new symlink.... 🤔 It is my birthday today so I will be offline for a bit with my family but it should be simple enough to patch later. How do you feel about the fix otherwise? |
|
I think the issue was just multiple copies of React. I've resolved it. The team will be a little slow reviewing due to a combination of some other priorities, the upcoming holidays, and current holidays. In the meantime, you can use it via patch-package or yarn patch or any of those kinds of tools. |
|
Sounds good! No rush I just hope it doesn't get lost in the holiday festivities 🍾 Thank you very very much for fixing the packages issues! Ill look into patching it locally for now and keep an eye on this PR :) |
Closes #9173
✅ Pull Request Checklist:
📝 Test Instructions:
Nest any component that uses Collections (Table, ListBox, Tabs...) within an Activity or a Next.js app route using cache components