Skip to content

Conversation

@mhornbacher
Copy link

Closes #9173

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Nest any component that uses Collections (Table, ListBox, Tabs...) within an Activity or a Next.js app route using cache components

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this. Let's see if we can get the PR checks passing.
You can run lint locally with yarn lint

@mhornbacher
Copy link
Author

@snowystinger added @storybook/blocks as well due to this failure

@mhornbacher
Copy link
Author

@snowystinger thanks for jumping in. Lets get this out!

I got most of the CI working but something seems up with the TS scripts... is this a known issue or is this introduced by this PR?

@mhornbacher
Copy link
Author

Hm, it looks like the issue is that it is a new symlink.... 🤔

It is my birthday today so I will be offline for a bit with my family but it should be simple enough to patch later.

How do you feel about the fix otherwise?

@snowystinger
Copy link
Member

I think the issue was just multiple copies of React. I've resolved it. The team will be a little slow reviewing due to a combination of some other priorities, the upcoming holidays, and current holidays. In the meantime, you can use it via patch-package or yarn patch or any of those kinds of tools.

@mhornbacher
Copy link
Author

Sounds good! No rush I just hope it doesn't get lost in the holiday festivities 🍾

Thank you very very much for fixing the packages issues! Ill look into patching it locally for now and keep an eye on this PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collection is not built when React.Activity is set to visible the first time

2 participants