fix(RAC): move native input inside the combobox div#9554
Merged
snowystinger merged 1 commit intoadobe:mainfrom Feb 6, 2026
Merged
fix(RAC): move native input inside the combobox div#9554snowystinger merged 1 commit intoadobe:mainfrom
snowystinger merged 1 commit intoadobe:mainfrom
Conversation
We have some form binding logic that depends on native form elements being inside the ref element. The current implementation of ComboBox breaks this design. This also makes it more difficult to access the native element for certain reasons (unless we add an extra div wrapper outside). I suggest changing the rendering structure of ComboBox to be consistent with Select, rendering the native form element inside the div instead of as a sibling.
snowystinger
approved these changes
Jan 29, 2026
Member
There was a problem hiding this comment.
I'm mostly fine moving it, it doesn't have the same issue as Select #8419 but I like having everything contained within a single root per component when possible.
It hasn't broken any of our tests.
My only hesitations is if anyone else ran into the same issue you did and worked around it by looking at the sibling. Overall though, I think this make more sense.
Going to run chromatic (VRT) on it.
Passed https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=1106
devongovett
approved these changes
Feb 6, 2026
Member
devongovett
left a comment
devongovett
left a comment
There was a problem hiding this comment.
I guess if we want to be consistent we should do the same for DatePicker etc.
yihuiliao
added
the
no testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some form binding logic that depends on native form elements being inside the ref element. The current implementation of ComboBox breaks this design. This also makes it more difficult to access the native element for certain reasons (unless we add an extra div wrapper outside). I suggest changing the rendering structure of ComboBox to be consistent with Select, rendering the native form element inside the div instead of as a sibling.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: