Skip to content

revert: revert resizeObserver#9576

Merged
snowystinger merged 2 commits intomainfrom
revert-resize-observer
Feb 3, 2026
Merged

revert: revert resizeObserver#9576
snowystinger merged 2 commits intomainfrom
revert-resize-observer

Conversation

@yihuiliao
Copy link
Member

@yihuiliao yihuiliao commented Feb 2, 2026

reverts: #7742

We found that after the merging this PR, the behavior of popover's in Safari changed.

  1. Make sure scrollbars are turned on
  2. Go to the S2 Popover storybook in Safari
  3. Go to the Autocomplete Popover story
  4. Make sure the control panel is opened at the bottom of the screen and reserves some space enough to cause the popover to vertically scroll the content inside
  5. Open the Popover

You should see the popover almost "vibrating", and if you move the mouse onto the search bar, it'll also "vibrate".

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

…ions' error when overlays get resized (#7742)"

This reverts commit 8a1ff6c.
@yihuiliao yihuiliao changed the title revert: revert resizeObserver (#7742) revert: revert resizeObserver #7742 Feb 2, 2026
@yihuiliao yihuiliao changed the title revert: revert resizeObserver #7742 revert: revert resizeObserver Feb 2, 2026
@rspbot
Copy link

rspbot commented Feb 3, 2026

@snowystinger snowystinger added this pull request to the merge queue Feb 3, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2026
@rspbot
Copy link

rspbot commented Feb 3, 2026

@snowystinger snowystinger added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit b679727 Feb 3, 2026
29 checks passed
@snowystinger snowystinger deleted the revert-resize-observer branch February 3, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants